Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servicedeployer/compose.go - pass env vars when signalling #1115

Merged
merged 1 commit into from
Jan 26, 2023
Merged

servicedeployer/compose.go - pass env vars when signalling #1115

merged 1 commit into from
Jan 26, 2023

Conversation

andrewkroh
Copy link
Member

Pass environment variables when invoking docker-compose to send a signal to a service.

Fixes #1114

@andrewkroh
servicedeployer/compose.go - pass env vars when signalling
28b5a4a 
Pass environment variables when invoking docker-compose to send a
signal to a service.

Fixes elastic#1114
@andrewkroh andrewkroh added the bug Something isn't working label Jan 26, 2023
@andrewkroh andrewkroh mentioned this pull request Jan 26, 2023
Closed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-26T01:32:56.927+0000

  • Duration: 33 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 878
Skipped 0
Total 878

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 65.909% (87/132) 👍
Classes 61.376% (116/189) 👍
Methods 48.642% (394/810) 👍
Lines 31.707% (3555/11212) 👎 -0.018
Conditionals 100.0% (0/0) 💚

jsoriano
jsoriano approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewkroh andrewkroh merged commit bddde65 into elastic:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[system testing] service_notify_signal fails when the service references env vars
3 participants
@andrewkroh @elasticmachine @jsoriano